Add ExtendedLogRecordBuilder#setException #7182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7182 +/- ##
============================================
- Coverage 89.98% 89.97% -0.02%
- Complexity 6685 6689 +4
============================================
Files 749 749
Lines 20191 20200 +9
Branches 1977 1977
============================================
+ Hits 18168 18174 +6
- Misses 1431 1433 +2
- Partials 592 593 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
approved these changes
Apr 10, 2025
sdk/trace/src/test/java/io/opentelemetry/sdk/trace/SdkSpanTest.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Per conversation in the 4/10/25 java SIG, I've broken out the configurable exception.* attribute value resolution into a separate PR, #7266. |
trask
changed the title
jaydeluca
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment
exception.*. Standardizing in the SDK "DRY"s up the instrumentation code, and provides a more familiar log API experience.Makesee commentexception.*resolution configurable -exception.*attributes are now resolved and attached to both span events and log records. This is an edge cases where the SDK specification has a dependency on the semantic conventions. It seems appropriate to make this a configurable extension point, so that users can customize things like theexception.stacktraceresolution.